3 comments:
File src/mainboard/asus/p5ql-em/romstage.c:
Patch Set #14, Line 85: pnp_write_config(GPIO_DEV, 0xf0, 0xf3); /* GPIO3 direction */
GPIO3x ?
Done
Patch Set #14, Line 87: pnp_write_config(GPIO_DEV, 0xf4, 0x06); /* GPIO4 direction */
GPIO4x ?
Done
Patch Set #14, Line 93: pnp_write_config(GPIO_DEV, 0xf1, old_reg | reg | 4);
Comments need improvement. Without opening the datasheet, I imagined GPIO32 as input.
Good now?
To view, visit change 31323. To unsubscribe, or for help writing mail filters, visit settings.