Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
mb/apple/macbookair4_2: Fix USB ports config

Disable unused ports and add comments.

Used 820-3023 board schematics as a source.

Change-Id: I2862546ca6f6929a86e77fae7337368742bb9ba8
Signed-off-by: Evgeny Zinoviev <me@ch1p.io>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50272
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/apple/macbookair4_2/early_init.c
1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/mainboard/apple/macbookair4_2/early_init.c b/src/mainboard/apple/macbookair4_2/early_init.c
index a32298d..7e2ec1b 100644
--- a/src/mainboard/apple/macbookair4_2/early_init.c
+++ b/src/mainboard/apple/macbookair4_2/early_init.c
@@ -6,20 +6,20 @@
#include <cbfs.h>

const struct southbridge_usb_port mainboard_usb_ports[] = {
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
- { 1, 0, -1 },
+ { 1, 0, -1 }, /* USB HUB 1 */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 1, 0, -1 }, /* USB HUB 2 */
+ { 1, 0, -1 }, /* Camera */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
+ { 0, 0, -1 }, /* Unused */
};

void mainboard_get_spd(spd_raw_data *spd, bool id_only)

To view, visit change 50272. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2862546ca6f6929a86e77fae7337368742bb9ba8
Gerrit-Change-Number: 50272
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged