Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao.
7 comments:
Patchset:
haven't completely reviewed everything in this patch yet, but it's probably better when i already post the comments on what i've found so far.
have you verified that a timeless build will result in identical images for a kahlee/grunt, a zork and a guybrush chromebook?
File util/amdfwtool/amdfwtool.h:
Patch Set #26, Line 240: uint8_t recovery_ab;
i'd use a boolean here; probably also the case for some of the struct elements above
File util/amdfwtool/amdfwtool.c:
this is a different type compared to cb_config->recovery_ab
Patch Set #26, Line 1351: psp_directory_table *pspdir, *pspdir2 = NULL, *pspdir2_b = NULL;
maybe put the 3 definitions on 3 separate lines
Patch Set #26, Line 1700: pspdir2_b = NULL; /* More explicitly */
since the corresponding if block has curly braces, please also use curly braces around the one statement in the else branch
NULL
Patch Set #26, Line 1733: , *biosdir2_b = NULL
i'd put this second definition on a new line to make it more obvious what's done here
To view, visit change 56773. To unsubscribe, or for help writing mail filters, visit settings.