1 comment:
File src/drivers/intel/fsp1_1/car.c:
Patch Set #30, Line 151: platform_enter_postcar();
> Why would we do this here? I don't think I'm following currently of the combinations of things we' […]
Ya. I'm aware of the mess. It's mainly my fault, but that's how I had to structure skl at the time to get vboot verification prior to romstage on that platform with fsp 1.1. There was no postcar, c_env_bootblock, or a consistent boot flow.
quark is a dead thing. I'm not sure people would notice if it was killed off in master branch. That said, I think we should understand the full combination of flows. Could you add a comment above each function indicating your current understanding of the combinations of things and for what platforms? I think that would help. Another dimension is when vboot starts and if its a separate stage or not.
To view, visit change 30686. To unsubscribe, or for help writing mail filters, visit settings.