View Change

15 comments:

• File src/soc/intel/common/block/cse/cse.c:

  • Patch Set #1, Line 516: if (!CONFIG(CONSOLE_SERIAL))

    that open brace { should be on the previous line

  • Patch Set #1, Line 520: if( offset == PCI_ME_HFSTS1)

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 520: if( offset == PCI_ME_HFSTS1)

    space required before the open parenthesis '('

• File src/soc/intel/common/block/include/intelblocks/cse.h:

  • Patch Set #1, Line 67: PCI_ME_HFSTS1 = 0x40,

    code indent should use tabs where possible

  • Patch Set #1, Line 67: PCI_ME_HFSTS1 = 0x40,

    please, no spaces at the start of a line

  • Patch Set #1, Line 68: PCI_ME_HFSTS2 = 0x48,

    code indent should use tabs where possible

  • Patch Set #1, Line 68: PCI_ME_HFSTS2 = 0x48,

    please, no spaces at the start of a line

  • Patch Set #1, Line 69: PCI_ME_HFSTS3 = 0x60,

    code indent should use tabs where possible

  • Patch Set #1, Line 69: PCI_ME_HFSTS3 = 0x60,

    please, no spaces at the start of a line

  • Patch Set #1, Line 70: PCI_ME_HFSTS4 = 0x64,

    code indent should use tabs where possible

  • Patch Set #1, Line 70: PCI_ME_HFSTS4 = 0x64,

    please, no spaces at the start of a line

  • Patch Set #1, Line 71: PCI_ME_HFSTS5 = 0x68,

    code indent should use tabs where possible

  • Patch Set #1, Line 71: PCI_ME_HFSTS5 = 0x68,

    please, no spaces at the start of a line

  • Patch Set #1, Line 72: PCI_ME_HFSTS6 = 0x6C,

    code indent should use tabs where possible

  • Patch Set #1, Line 72: PCI_ME_HFSTS6 = 0x6C,

    please, no spaces at the start of a line

To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.