Patch Set 18:

Patch Set 18:

And kconfig is not just disappearing its been replaced with some code which might not meet your requirement, i want to understand that.

I am only critisizing the silent removal of 'RELOCATABLE_RAMSTAGE'. It is a pretty fundamental Kconfig. Sure, you are replacing it, but there is no mention of doing so in the commit message.
There was some chance of this being merged just before 4.10 release, thus my -2. I don't have proper understanding about possible new stage cache requirements triggering this particular commit.

As a background info, I believe I am the one who brought most of pre-Haswell Intels and AGESA/binaryPI AMD CPUs all the way through STATIC_CBMEM, DYNAMIC_CBMEM, EARLY_CBMEM_INIT, RELOCATABLE_RAMSTAGE and finally POSTCAR_STAGE phases. I guess I should know, but is there something fundamentally wrong with the name 'RELOCATABLE_RAMSTAGE'? We have had it for maybe six years like that. And from day one, it has implied parts other than the ramstage are also relocatable.

I can add more description in commit msg, will wait for Furquan's further review before new patchset.

Btw, i don't understand if i need to wait for Oct'19 to merge this changes ?

View Change

To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.