15 comments:
File src/mainboard/amd/padmelon/Kconfig:
Patch Set #3, Line 64: Oddly enough,
Remove the commentary?
an
# Don't use AMD's Secure OS
config USE_PSPSECUREOS
def_bool n
Ok.
File src/mainboard/amd/padmelon/bootblock/OemCustomize.c:
Patch Set #3, Line 143: 0x00172051, 0x001721C7, 0x00172222, 0x00172310,
Does padmelon use the same codec as gardenia? If not, these should probably be updated.
File src/mainboard/amd/padmelon/bootblock/bootblock.c:
UART
Patch Set #3, Line 37: 0x3fb
Use the register values in drivers/uart/8350reg.h for these values?
Is padmelon restricted to using this serial port at 3f8? If not, consider not hardcoding the base address.
File src/mainboard/amd/padmelon/fan_init.c:
Patch Set #3, Line 29: celcius
celsius?
Patch Set #3, Line 30: cpu_boudaries
boundaries
Patch Set #3, Line 106: return
Maybe consider returning a value so you can print a warning that the setup wasn't completed?
Patch Set #3, Line 115: 0x0220, 0xff
Maybe some #defines to say what these are?
Patch Set #3, Line 131: register
Maybe describe WHAT register is being restored?
File src/mainboard/amd/padmelon/irq_tables.c:
/* Align the table to be 16 byte aligned. */
addr += 15;
addr &= ~15;
Isn't there a macro to do this?
Patch Set #3, Line 65: PCI_DEVFN(0x14, 4);
Macro?
Patch Set #3, Line 69: 0x1002
Don't we have #defines for these?
Patch Set #3, Line 80: PCI_DEVFN(0x14, 4)
macro?
To view, visit change 33993. To unsubscribe, or for help writing mail filters, visit settings.