Attention is currently required from: Nico Huber, Matt DeVillier, Angel Pons, Arthur Heymans, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55810 )
Change subject: broadwell boards: Do not set `ddr_refresh_2x` again
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/auron/variants/buddy/spd/spd.c:
https://review.coreboot.org/c/coreboot/+/55810/comment/cecaf1ea_8de02925
PS9, Line 13: pei_data->ddr_refresh_2x = 1;
What difference would it make? soc/intel/broadwell/pei_data. […]
I looked through the (internal) board's development history. For this family rowhammer mitigations came in time so that there's no RO out there without double refresh. This is good to go in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76478689b3aa27c369a0413d9fbde03674d5e528
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 22:08:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment