> What is UAER
Sorry UART.

What is there to set up?
The UART hardware.

Why should coreboot do it?
Because coreboot sets up the hardware.


> This also goes along with the following patches to set up the SPCR ACPI table.

This has `console` in its name, why is it useful without console?

The coreboot console is not the only thing the serial port can be used for. It's not the only console. Enabling the coreboot console slows down the boot process considerably, so in my opinion, it's entirely reasonable to leave the coreboot serial console disabled, but still want to have the serial port set up.

I don't understand the argument. If you or anyone else doesn't want to use this feature, don't enable it. Sure, there's still some work to do on the patch, but your arguments make it seem like you're about to give it a -2, and I don't understand the objection.


View Change

To view, visit change 33380. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0942634ab8a9fcafdc1ea099721c127202e9f9a
Gerrit-Change-Number: 33380
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Wed, 12 Jun 2019 03:07:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment