Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu.

Patch set 9:Code-Review +1

View Change

2 comments:

• File src/drivers/intel/fsp2_0/include/fsp/util.h:

  • Patch Set #9, Line 122: /* Helper function to print a message concatenated with the a FSP return status. */

    Can we print 64bits status for both 32bit and 64bit mode to simplify code?
    I think it should not impact for both cases.

• File src/drivers/intel/fsp2_0/memory_init.c:

  • Patch Set #7, Line 42:

    Absolutely ! I just wanted the decision to be collegial. […]

    I also think we can simplify 16 byte align for both cases.

To view, visit change 80277. To unsubscribe, or for help writing mail filters, visit settings.