1 comment:
Patch Set #1, Line 10: location across early stages, and not necessarily within the
This came about from adding a bootblock/romstage implementation, which I gathered you wanted (but I' […]
I am not the one giving -2/+2 on this question, but I'll give my opinions anyway.
a) I believe x86 CAR approach uses shared .bss for ENV_ROMSTATE_OR_BEFORE because it has to, not because we want it to. CAR is a restricted resource and the setup is volatile which has to be done in bootblock already. It's not really possible for romstage to extend the .bss region that was setup in cache-as-ram.S.
b) IMHO .bss within program(.ld) is the clean approach, and with DRAM available the complications of CAR do not apply. This would be the same approach ARCH_ARM uses already? I would choose wasting some tens of KiB of DRAM (from OS) over toolchain complications.
c) As far as wasted DRAM is concerned, I don't know why you would want to keep the DRAM bootblock/verstage/romstage used reserved from OS, one should be allowed to discard those early in ramstage. I have not tried to understand or visualise your plans for S3 resume path, nor do I have access to required documentation. Solution where S3 resume path only uses memory in CBMEM or TSEG would be preferred to avoid any low-memory reservations or backups.
To view, visit change 37487. To unsubscribe, or for help writing mail filters, visit settings.