Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34112 )
Change subject: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig@509
PS3, Line 509: default
Minor: Would 'depends' be better here?
Hmm... no? I don't know what you would want this to look like.
https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kconf...
File src/cpu/allwinner/a10/Kconfig:
https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kconf...
PS3, Line 13: select NO_MONOTONIC_TIMER
Does this chip have a monotonic timer or not?
Did you see the "implementation" file removed here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dfa9b92dc63375465e3bb87b73eeefad601c810
Gerrit-Change-Number: 34112
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 07 Jul 2019 10:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment