Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/31284/11/src/soc/intel/cannonlake/fsp_params... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31284/11/src/soc/intel/cannonlake/fsp_params... PS11, Line 69: config->SerialIoDevMode[SerialIoDevOffset];
80?
https://review.coreboot.org/#/c/31284/11/src/soc/intel/cannonlake/romstage/f... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/31284/11/src/soc/intel/cannonlake/romstage/f... PS11, Line 109: remove ?