Attention is currently required from: Kyösti Mälkki.

Arthur Heymans uploaded patch set #5 to this change.

View Change

drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic

The size of the data used is fixed in this function so there is no
need for this aritmetic.

The function signature will be changed in a followup commit.

The cache_disable call is dropped as all the codepaths calling the
restore_mtrr function do this already.


Change-Id: I3c6df8951d39695cddd4635360d6407d4d001b0a
Signed-off-by: Arthur Heymans <>
M src/drivers/amd/agesa/oem_s3.c
M src/drivers/amd/agesa/s3_mtrr.c
2 files changed, 54 insertions(+), 93 deletions(-)

git pull ssh:// refs/changes/93/44293/5

To view, visit change 44293. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c6df8951d39695cddd4635360d6407d4d001b0a
Gerrit-Change-Number: 44293
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <>
Gerrit-Reviewer: Kyösti Mälkki <>
Gerrit-Reviewer: Michał Żygowski <>
Gerrit-Reviewer: Mike Banon <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Arthur Heymans <>
Gerrit-CC: Michał Kopeć <>
Gerrit-CC: Paul Menzel <>
Gerrit-Attention: Kyösti Mälkki <>
Gerrit-MessageType: newpatchset