IMHO, if the SoCs are similar, copy-pasting a bunch of code which results in two similar codebases doesn't make sense, and probably results in some extra maintenance burden. I'd rather see common code instead (to the extent that is possible).

IMHO, if the SoCs differ significantly, copy-pasting code then changing it sounds completely insane. I doubt that this is the case here, but in case it is, I believe the most logical approach would be "starting fresh", i.e., adding properly updated files from the start, in a patch train.

NB I am not an expert and may be mistaken.

Patch set 1:Code-Review -1

View Change

To view, visit change 32407. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6809bd1eea304f76dd9000c079b3ed09f94dbd3b
Gerrit-Change-Number: 32407
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 26 Apr 2019 15:01:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment