Patrick Georgi merged this change.
payloads/coreinfo: Free buffer before returning
This fixes a memory leak, which was partially resolved in
2d1e0eb (payloads/coreinfo: Free buffer before returning).
Found-by: Coverity Scan, CID 1373370 (RESOURCE_LEAK)
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: I0efe94b9dfb27746828055427029c01c7f407ec2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32094
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M payloads/coreinfo/timestamps_module.c
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/payloads/coreinfo/timestamps_module.c b/payloads/coreinfo/timestamps_module.c
index 0978f31..fe2d2b5 100644
--- a/payloads/coreinfo/timestamps_module.c
+++ b/payloads/coreinfo/timestamps_module.c
@@ -203,8 +203,10 @@
SCREEN_X, LINES_SHOWN);
/* Sanity check, chars_count must be padded to full line */
- if (chars_count % SCREEN_X != 0)
+ if (chars_count % SCREEN_X != 0) {
+ free(buffer);
return -2;
+ }
g_lines_count = chars_count / SCREEN_X;
g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0);
To view, visit change 32094. To unsubscribe, or for help writing mail filters, visit settings.