Patch Set 18: Code-Review-2
That variable "RELOCATABLE_RAMSTAGE" has some amount of conceptional significance over the stage caches. We have also used it as criteria for board removals in past discussion on the mailing list.
I am too much unhappy about the Kconfig just disappering like this, thus my -2 here now, until we have some more reviewer opinions. At least, can you keep the Kconfig as a placeholder and keep all the existing cases of CONFIG(RELOCATABLE_RAMSTAGE) unmodified?
yes, i can keep RELOCATABLE_RAMSTAGE KConfig as is but if i don't modify .inc and .c then what this CL will do.
Please review with an opinion what we like to achieve and share feedback if you think its not meeting your requirement.
I believe review comment has enough description (from Furquan, Arthur) about why we started cleaning this stage_cache logic. Today entire stage_cache logic is tied with RAMSTAGE which shouldn't be the case as i understand, stage_cache is something well beyond ramstage.
And kconfig is not just disappearing its been replaced with some code which might not meet your requirement, i want to understand that.
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.