View Change

4 comments:

• File src/mainboard/google/cheza/chromeos.fmd:

  • Patch Set #76, Line 27: (

    nit: flags are normally written without space before the parenthesis (compare COREBOOT(CBFS) above).

    Ack

• File src/soc/qualcomm/sdm845/include/soc/memlayout.ld:

  • Patch Set #76, Line 31: 8192

    nit: 8K

    Ack

• File src/soc/qualcomm/sdm845/include/soc/qclib.h:

  • Patch Set #69, Line 52: #define QCLIB_GA_ENABLE_UART_LOGGING 0x00000001

    Yeah, it doesn't really matter, it just makes it easier for me because I don't always get the new Qc […]

    Just sent yet another email query on this issue and added it to my Daily ToDo list.
    I will try to have an update Thursday morning as the India team is responsible for these releases.

• File src/soc/qualcomm/sdm845/qclib.c:

  • Patch Set #76, Line 43: if (size < 0)

    This must be a different variable that's ssize_t.

    Ack
    Wonder why the compiler didn't alert, must be same size?

To view, visit change 25208. To unsubscribe, or for help writing mail filters, visit settings.