3 comments:
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
Patch Set #13, Line 57: static size_t last_set_spd_data_len;
The variable is static, so it will have a definite memory address. […]
OK, SGTM.
Patch Set #13, Line 59: assert(spd_data_ptr && spd_data_len);
Please explicitly test spd_data_len != 0 instead of relying on C language behavior to convert an int […]
Done
Patch Set #13, Line 61: if (last_set_spd_data_len && last_set_spd_data_len != spd_data_len)
Please explicitly test last_set_spd_data_len != 0. […]
Done
To view, visit change 32513. To unsubscribe, or for help writing mail filters, visit settings.