Patch Set 1:

Patch Set 1:

Did you compare testing results between CML-H and other platforms like SKL/KBL-H?

Yes, SHL/KBL H also has total 8 SATA port. The only difference is SPD bit definitions there. thats we have already handled like this

https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/sata/Kconfig#L6

Difference between H and LP would be for SATA, LP has 0-2 implemented and rest 3-7 reserved.

I wonder why I had no problems with this on X11SSM-F (100series PCH-H) so far
May your SATA direct connect Port is between 0-2, else you would also see this issue for sure.

I have 8 SATA Ports and use 2-6 and there are no problems

View Change

To view, visit change 41674. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied3832b26ba1fdd4c30fafe8149689a01d302c3e
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-CC: Lance Zhao <lance.zhao@gmail.com>
Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 24 May 2020 12:44:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment