Patch Set 1:
Patch Set 1:
(1 comment)
Documentation is now provided in Markdown format, please keep that in mind. This may be helpful: https://doc.coreboot.org/getting_started/writing_documentation.html
Also, it is worth noting that the documentation from old wiki may be outdated, so a sanity check on anything imported from the old wiki is definitely needed.
Reworked and updated with my findings, please review at:
https://review.coreboot.org/c/coreboot/+/30896
I see... The idea of code review on gerrit is to work on one change and keep updating it until it is good enough. Then it gets merged in its final form. Therefore, creating a different commit on gerrit to update a change is unnecessary.
Say, for instance, that you would like to update this change. Just click the download button, select "cherry-pick" (there is a button to copy the listed command) and run the command on your computer, on the coreboot git repo, which will create a local commit (if it does not exist already). Then you can work locally on the change. Once you are done, "git add" what you have changed and "git commit --amend" the commit you cherry-picked (or previously had). Then, when you push the amended commit, it will update the existing change.
This only works as long as the "Change-Id:" git-tag (line in the commit message) is not changed, since this is what gerrit uses to keep track of changes.
Now you have two changes on gerrit: CB:30895 and CB:30896. Choose which one you would like to work on and please abandon the other since it is redudant. Thank you.
To view, visit change 30895. To unsubscribe, or for help writing mail filters, visit settings.