Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
src: Capitalize Super I/O

Change-Id: I9ad9294dd2ae3e4a8a9069ac6464ad753af65ea5
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35541
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
---
M Documentation/mainboard/asrock/h81m-hds.md
M Documentation/mainboard/asus/p8h61-m_lx.md
M Documentation/mainboard/asus/p8h61-m_pro.md
M Documentation/mainboard/supermicro/x10slm-f.md
M src/device/pnp_device.c
M src/mainboard/roda/rv11/variants/rv11/include/acpi/superio.asl
M src/superio/acpi/pnp_generic.asl
M src/superio/acpi/pnp_kbc.asl
M src/superio/acpi/pnp_uart.asl
9 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/Documentation/mainboard/asrock/h81m-hds.md b/Documentation/mainboard/asrock/h81m-hds.md
index df00abd..6a0da5b 100644
--- a/Documentation/mainboard/asrock/h81m-hds.md
+++ b/Documentation/mainboard/asrock/h81m-hds.md
@@ -70,7 +70,7 @@
- The VGA port doesn't work until the OS reinitialises the display.

- There is no automatic, OS-independent fan control. This is because
- the super I/O hardware monitor can only obtain valid CPU temperature
+ the Super I/O hardware monitor can only obtain valid CPU temperature
readings from the PECI agent, but the required driver doesn't exist
in coreboot. The `coretemp` driver can still be used for accurate CPU
temperature readings from an OS.
diff --git a/Documentation/mainboard/asus/p8h61-m_lx.md b/Documentation/mainboard/asus/p8h61-m_lx.md
index 5eb7193..212ed97 100644
--- a/Documentation/mainboard/asus/p8h61-m_lx.md
+++ b/Documentation/mainboard/asus/p8h61-m_lx.md
@@ -49,7 +49,7 @@
suspend.

- There is no automatic, OS-independent fan control. This is because
- the super I/O hardware monitor can only obtain valid CPU temperature
+ the Super I/O hardware monitor can only obtain valid CPU temperature
readings from the PECI agent, whose complete initialisation is not
publicly documented. The `coretemp` driver can still be used for
accurate CPU temperature readings.
diff --git a/Documentation/mainboard/asus/p8h61-m_pro.md b/Documentation/mainboard/asus/p8h61-m_pro.md
index 169678e..713c794 100644
--- a/Documentation/mainboard/asus/p8h61-m_pro.md
+++ b/Documentation/mainboard/asus/p8h61-m_pro.md
@@ -46,7 +46,7 @@
## Known issues

- There is no automatic, OS-independent fan control. This is because
- the super I/O hardware monitor can only obtain valid CPU temperature
+ the Super I/O hardware monitor can only obtain valid CPU temperature
readings from the PECI agent, whose complete initialisation is not
publicly documented. The `coretemp` driver can still be used for
accurate CPU temperature readings.
diff --git a/Documentation/mainboard/supermicro/x10slm-f.md b/Documentation/mainboard/supermicro/x10slm-f.md
index 7fae61f..acb2c84 100644
--- a/Documentation/mainboard/supermicro/x10slm-f.md
+++ b/Documentation/mainboard/supermicro/x10slm-f.md
@@ -168,7 +168,7 @@
- VGA graphics
- disabling VGA graphics using the jumper
- hiding the AST2400 using the CMOS setting
-- super I/O hardware monitor (see [Known issues](#known-issues))
+- Super I/O hardware monitor (see [Known issues](#known-issues))
- initialisation with Haswell MRC version 1.6.1 build 2
- flashrom under coreboot
- Wake-on-LAN
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c
index 164fc19..28a45d0 100644
--- a/src/device/pnp_device.c
+++ b/src/device/pnp_device.c
@@ -109,7 +109,7 @@
static void pnp_set_resource(struct device *dev, struct resource *resource)
{
if (!(resource->flags & IORESOURCE_ASSIGNED)) {
- /* The PNP_MSC super IO registers have the IRQ flag set. If no
+ /* The PNP_MSC Super IO registers have the IRQ flag set. If no
value is assigned in the devicetree, the corresponding
PNP_MSC register doesn't get written, which should be printed
as warning and not as error. */
diff --git a/src/mainboard/roda/rv11/variants/rv11/include/acpi/superio.asl b/src/mainboard/roda/rv11/variants/rv11/include/acpi/superio.asl
index d1b2193..9de6da0 100644
--- a/src/mainboard/roda/rv11/variants/rv11/include/acpi/superio.asl
+++ b/src/mainboard/roda/rv11/variants/rv11/include/acpi/superio.asl
@@ -1 +1 @@
-/* no super i/o */
+/* no Super I/O */
diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl
index 980404e..dbae2ac 100644
--- a/src/superio/acpi/pnp_generic.asl
+++ b/src/superio/acpi/pnp_generic.asl
@@ -20,9 +20,9 @@
*
* Controlled by the following preprocessor defines:
*
- * SUPERIO_CHIP_NAME The name of the super i/o chip (unique, required)
+ * SUPERIO_CHIP_NAME The name of the Super I/O chip (unique, required)
* SUPERIO_PNP_HID The EisaId string that identifies this device (optional)
- * SUPERIO_PNP_LDN The logical device number on the super i/o
+ * SUPERIO_PNP_LDN The logical device number on the Super I/O
* chip for this device (required)
* SUPERIO_PNP_DDN A string literal that identifies the dos device
* name (DDN) of this device (e.g. "COM1", optional)
diff --git a/src/superio/acpi/pnp_kbc.asl b/src/superio/acpi/pnp_kbc.asl
index cbcfd55..541dce3 100644
--- a/src/superio/acpi/pnp_kbc.asl
+++ b/src/superio/acpi/pnp_kbc.asl
@@ -22,8 +22,8 @@
*
* Controlled by the following preprocessor defines:
*
- * SUPERIO_CHIP_NAME The name of the super i/o chip (unique, required)
- * SUPERIO_KBC_LDN The logical device number on the super i/o
+ * SUPERIO_CHIP_NAME The name of the Super I/O chip (unique, required)
+ * SUPERIO_KBC_LDN The logical device number on the Super I/O
* chip for this keyboard controller (required)
* SUPERIO_KBC_PS2M If defined, PS/2 mouse support is included in
* the KBC_LDN. Mouse irq is set at IRQ1 of the
diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl
index f42cc42..3cbe65a 100644
--- a/src/superio/acpi/pnp_uart.asl
+++ b/src/superio/acpi/pnp_uart.asl
@@ -21,8 +21,8 @@
*
* Controlled by the following preprocessor defines:
*
- * SUPERIO_CHIP_NAME The name of the super i/o chip (unique, required)
- * SUPERIO_UART_LDN The logical device number on the super i/o
+ * SUPERIO_CHIP_NAME The name of the Super I/O chip (unique, required)
+ * SUPERIO_UART_LDN The logical device number on the Super I/O
* chip for this UART (required)
* SUPERIO_UART_DDN A string literal that identifies the dos device
* name (DDN) of this uart (e.g. "COM1", optional)

To view, visit change 35541. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad9294dd2ae3e4a8a9069ac6464ad753af65ea5
Gerrit-Change-Number: 35541
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged