11 comments:
File src/soc/mediatek/mt8192/dramc_utility.c:
Patch Set #28, Line 17: /* frequency freq_group div_mode shuffle_saved vref_cali vcore*/
Given that the struct definition is few lines above, I don't think we need this comment.
One space after ":".
One space after ":".
Patch Set #28, Line 125: get_highest_freq_group
Doesn't this always return DDRFREQ_2133?
Same.
Patch Set #28, Line 141: freq_shuffle_table[k_shu]
Declare a local variable for this?
One space after ":"
One space before "("
Patch Set #28, Line 153: dramc_dbg("cali data(size:%ld) use fsp:%d, freq_group:%d, div_mode:%d, shu:%d, vref_cali:%d, odt_onoff:%d, vcore:%d\n",
Line too long (> 96 chars)
No need for parentheses.
Patch Set #28, Line 164: MISC_STATUSA_REFRESH_QUEUE_CNT
Please align with "READ32_BITFIELD".
To view, visit change 44700. To unsubscribe, or for help writing mail filters, visit settings.