Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
mb/amd/onyx_poc: Add and use APCB configuration data

This patch adds APCB blobs to the mainboard directory and it replaces
CB:76445 Also this brings onyx_poc mainboard inline with how APCB are
included in other AMD mainboard: commit 95d05d830162 ("mb/google/zork:
Add and use APCB configuration data"), commit I352f58e0d39 ("mb/google/
skyrim: Add and use APCB configuration data") and commit I1c34528fa0f
("mb/amd/onyx_poc: Add and use APCB configuration data").

BUG=none
TEST=build/boot onyx_poc

Change-Id: I1c34528fa0fd15b847c22c995713078c60ac3873
Signed-off-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80204
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/amd/onyx_poc/Makefile.mk
A src/mainboard/amd/onyx_poc/data.apcb
A src/mainboard/amd/onyx_poc/data1.apcb
A src/mainboard/amd/onyx_poc/data_rec.apcb
A src/mainboard/amd/onyx_poc/data_rec1.apcb
A src/mainboard/amd/onyx_poc/data_rec2.apcb
6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/amd/onyx_poc/Makefile.mk b/src/mainboard/amd/onyx_poc/Makefile.mk
index 4ebcf26..5ee83d4 100644
--- a/src/mainboard/amd/onyx_poc/Makefile.mk
+++ b/src/mainboard/amd/onyx_poc/Makefile.mk
@@ -1,11 +1,11 @@
## SPDX-License-Identifier: GPL-2.0-only

-ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/Typex60_0_0_0_Apcb.bin),)
-APCB_SOURCES = $(MAINBOARD_BLOBS_DIR)/Typex60_0_0_0_Apcb.bin
-APCB_SOURCES1 = $(MAINBOARD_BLOBS_DIR)/Typex60_0_1_0_Apcb.bin
-APCB_SOURCES_RECOVERY = $(MAINBOARD_BLOBS_DIR)/Typex68_0_0_0_ApcbRec.bin
-APCB_SOURCES_RECOVERY1 = $(MAINBOARD_BLOBS_DIR)/Typex68_0_8_0_ApcbRec.bin
-APCB_SOURCES_RECOVERY2 = $(MAINBOARD_BLOBS_DIR)/Typex68_0_9_0_ApcbRec.bin
+ifneq ($(wildcard $(src)/mainboard/$(MAINBOARDDIR)/data.apcb),)
+APCB_SOURCES = $(src)/mainboard/$(MAINBOARDDIR)/data.apcb
+APCB_SOURCES1 = $(src)/mainboard/$(MAINBOARDDIR)/data1.apcb
+APCB_SOURCES_RECOVERY = $(src)/mainboard/$(MAINBOARDDIR)/data_rec.apcb
+APCB_SOURCES_RECOVERY1 = $(src)/mainboard/$(MAINBOARDDIR)/data_rec1.apcb
+APCB_SOURCES_RECOVERY2 = $(src)/mainboard/$(MAINBOARDDIR)/data_rec2.apcb
else
show_notices:: warn_no_apcb
endif
diff --git a/src/mainboard/amd/onyx_poc/data.apcb b/src/mainboard/amd/onyx_poc/data.apcb
new file mode 100644
index 0000000..76219a4
--- /dev/null
+++ b/src/mainboard/amd/onyx_poc/data.apcb
Binary files differ
diff --git a/src/mainboard/amd/onyx_poc/data1.apcb b/src/mainboard/amd/onyx_poc/data1.apcb
new file mode 100644
index 0000000..015123f
--- /dev/null
+++ b/src/mainboard/amd/onyx_poc/data1.apcb
Binary files differ
diff --git a/src/mainboard/amd/onyx_poc/data_rec.apcb b/src/mainboard/amd/onyx_poc/data_rec.apcb
new file mode 100644
index 0000000..ce36636
--- /dev/null
+++ b/src/mainboard/amd/onyx_poc/data_rec.apcb
Binary files differ
diff --git a/src/mainboard/amd/onyx_poc/data_rec1.apcb b/src/mainboard/amd/onyx_poc/data_rec1.apcb
new file mode 100644
index 0000000..1267ff9
--- /dev/null
+++ b/src/mainboard/amd/onyx_poc/data_rec1.apcb
Binary files differ
diff --git a/src/mainboard/amd/onyx_poc/data_rec2.apcb b/src/mainboard/amd/onyx_poc/data_rec2.apcb
new file mode 100644
index 0000000..4fb24b3
--- /dev/null
+++ b/src/mainboard/amd/onyx_poc/data_rec2.apcb
Binary files differ

To view, visit change 80204. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c34528fa0fd15b847c22c995713078c60ac3873
Gerrit-Change-Number: 80204
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit Pandya <pandyavarshit@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged