1 comment:
for (res = dev->resource_list; res; res = res->next)
pci_set_resource(dev, res, &command_mask);
/* If there are unassigned resources, we might
have to disable others of the same type. */
dev->command &= command_mask;
> I am thinking if we should just split bridge and non-bridge resource setting completely. […]
Agreed. We need to be careful about the command bits. Having a helper function get_command_bits(res) can return the right mask to set / clear.
1) Bridge --> a) Always set the mask using get_command_bits(res)
2) Non-bridge --> Get mask using get_command_bits(res), a) Set if resource is valid, b) Clear if resource is invalid and exit.
Hence, the order above is important where bridge resources are considered first and then the non-bridge resources.
With that the 4 cases would be:
To view, visit change 41553. To unsubscribe, or for help writing mail filters, visit settings.