17 comments:
File src/soc/mediatek/mt8192/include/soc/addressmap.h:
Patch Set #2, Line 8: MCUPM_SRAM_BASE = 0x0C540000,
please, no spaces at the start of a line
Patch Set #2, Line 9: MCUPM_CFG_BASE = 0x0C560000,
please, no spaces at the start of a line
File src/soc/mediatek/mt8192/mcupm.c:
Patch Set #2, Line 15: const char *file_name = "mcupm.bin";
please, no spaces at the start of a line
Patch Set #2, Line 16: size_t fw_size = cbfs_boot_load_file(file_name,
please, no spaces at the start of a line
Patch Set #2, Line 17: mcupm_bin,
code indent should use tabs where possible
Patch Set #2, Line 17: mcupm_bin,
please, no spaces at the start of a line
Patch Set #2, Line 18: sizeof(mcupm_bin),
code indent should use tabs where possible
Patch Set #2, Line 18: sizeof(mcupm_bin),
please, no spaces at the start of a line
Patch Set #2, Line 19: CBFS_TYPE_RAW);
code indent should use tabs where possible
Patch Set #2, Line 19: CBFS_TYPE_RAW);
please, no spaces at the start of a line
Patch Set #2, Line 21: if (fw_size == 0) {
please, no spaces at the start of a line
Patch Set #2, Line 21: if (fw_size == 0) {
braces {} are not necessary for single statement blocks
Patch Set #2, Line 22: die("MCUPM file :mcupm.bin not found.");
code indent should use tabs where possible
Patch Set #2, Line 22: die("MCUPM file :mcupm.bin not found.");
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #2, Line 27: memcpy((void *)MCUPM_SRAM_BASE, mcupm_bin, fw_size);
please, no spaces at the start of a line
File src/soc/mediatek/mt8192/soc.c:
Patch Set #2, Line 17: mcupm_init();
please, no spaces at the start of a line
To view, visit change 46392. To unsubscribe, or for help writing mail filters, visit settings.