Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49017 )
Change subject: SMBIOS: Allow separation of mainboard and baseboard manufacturer. ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49017/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49017/1//COMMIT_MSG@7 PS1, Line 7: SMBIOS: Allow separation of mainboard and baseboard manufacturer. It doesn't seem like SMBIOS is making this distinction. For type 2:
"[...], the information in this structure defines attributes of a system baseboard (for example, a motherboard, planar, server blade, or other standard system module)."
https://review.coreboot.org/c/coreboot/+/49017/1//COMMIT_MSG@10 PS1, Line 10: manufacturer information in the DMI Type 1 and Type 2 tables. For type 1 we call smbios_system_manufacturer() and for type 2 smbios_mainboard_manufacturer(). So they can already be overridden individually.
https://review.coreboot.org/c/coreboot/+/49017/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/49017/1/src/arch/x86/smbios.c@a570 PS1, Line 570: t->manufacturer = smbios_add_string(t->eos, smbios_mainboard_manufacturer()); After this change, nothing is calling smbios_mainboard_manufacturer() directly anymore. Seems odd.