Attention is currently required from: Nico Huber, Furquan Shaikh, Jamie Ryu, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Raj Astekar, Aaron Durbin, Patrick Rudolph.
7 comments:
Commit Message:
Patch Set #6, Line 10: LAPIC_BASE_MSR(LAPIC_BASE_MSR_X2APIC_MODE)
Please add a space before the (.
Done
Patch Set #6, Line 11: implment
implement
Done
Patch Set #6, Line 21: cat /proc/cpuinfo | grep "apicid"
I don't like the grep-only approach, especially when I want to change what I'm grepping for. […]
Done
File src/cpu/x86/lapic/lapic_cpu_init.c:
Patch Set #6, Line 355: LAPIC_DM_INIT | LAPIC_INT_LEVELTRIG, id);
No need to break the line here.
Done
File src/cpu/x86/mp_init.c:
Patch Set #6, Line 458: } else {
Or even better, add more functions. e.g. start_aps_lapic(), start_aps_lx2apic(). […]
Done
Patch Set #6, Line 678: } else {
Simpler: […]
Done
File src/include/cpu/x86/lapic_def.h:
Patch Set #6, Line 99: #define X2APIC_LAPIC_ID (X2APIC_MSR_BASE_ADDRESS | (LAPIC_ID >> 4))
These definitions are misplaced (they're not fields in LAPIC_TDCR, not even LAPIC registers)
Done
To view, visit change 51723. To unsubscribe, or for help writing mail filters, visit settings.