Patch Set 6:

Cherry-picked this. On my DUT, it got stuck:

Starting depthcharge on Deltan...
WARNING: can't convert coreboot GPIOs, 'lid' won't be resampled at runtime!
WARNING: can't convert coreboot GPIOs, 'power' won't be resampled at runtime!
WARNING: can't convert coreboot GPIOs, 'EC in RW' won't be resampled at runtime!
BIOS MMAP details:
IFD Base Offset : 0x1000000
IFD End Offset : 0x2000000
MMAP Size : 0x1000000
MMAP Start : 0xff000000
Wilco EC [base 0x0940 emi 0x0950] flash 0x00001000-0x00100fff
Looking for NVMe Controller 0x32038558 @ 00:1d:00
Wipe memory regions:
[0x00000000001000, 0x000000000a0000)
[0x00000000100000, 0x00000030000000)
[0x0000003263be20, 0x00000076a0f000)
[0x00000100000000, 0x00000180400000)
xhci_wait_for_command: Command ring still running ===> Stuck here forever!

That sounds irrational as the patch only disables TBT root ports BME. The "xhci_wait_for_command: Command ring still running;" refers to lippayload xhci's CRR check. On our sides, multiple DUT boot reliably to kernel either from nvme or usb after cherry-pick this patch.

View Change

To view, visit change 40968. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9650b9dd4df1f9bee53ae3737b7bf60b2ef8017b
Gerrit-Change-Number: 40968
Gerrit-PatchSet: 6
Gerrit-Owner: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Alex Levin <levinale@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Divya S Sasidharan <divya.s.sasidharan@intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Prashant Malani <pmalani@google.com>
Gerrit-Reviewer: Shamile Khan <shamile.khan@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.corp-partner.google.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 12 May 2020 00:16:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment