Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 44:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/apollolake/m... File src/soc/intel/apollolake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/apollolake/m... PS44, Line 37: if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE)) This guard should be removed like the rest of the files.
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... PS44, Line 347: PRMRR_SIZE Nit. This Kconfig variable is actually in MiB. Name it accordingly?
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/35799/44/src/soc/intel/common/block... PS44, Line 165: the a Just 'the'.