Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph, Paul Menzel, Saurabh Mishra, Subrata Banik.

View Change

3 comments:

• File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

  • Patch Set #2, Line 80:

    const uint8_t *byte_ptr = (const uint8_t *)data;
    	size_t bytes_to_copy;
    	union {
    		uint32_t full;
    		uint8_t bytes[4];
    	} dword;
    
    	for (size_t i = 0; i < len; i += 4) {
    		dword.full = 0;
    
    		bytes_to_copy = (len - i < 4) ? len - i : 4;
    		for (size_t j = 0; j < bytes_to_copy; j++)
    			dword.bytes[j] = byte_ptr[i + j];
    
    		write32p(ctx->mmio_base + SPIBAR_FDATA(i >> 2), dword.full);
    	}
    

    OK. Marking this as unresolved until the patch is actually updated.

    Done

• File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

  • Patch Set #4, Line 81: (len >> 2)

    This optimisation can be done by the compiler. […]

    Done

  • Patch Set #4, Line 85: (len & 3)

    Same here, please use `len % 4`

    Done

To view, visit change 82079. To unsubscribe, or for help writing mail filters, visit settings.