Patch set 33:Code-Review +1
19 comments:
File Documentation/mainboard/51nb/x210.jpg:
Maybe crop this image a bit, so that it is under 50 KiB?
File Documentation/mainboard/51nb/x210.md:
Patch Set #33, Line 48: Use libgfxinit once Kaby Lake is supported.
Done, I guess?
Patch Set #8, Line 23: /* Enable function 5 (PS/2 AUX) */
Some ECs have a SuperIO-like part. See ec/roda/it8518 for an example.
Ack
Patch Set #8, Line 43: CHIP_NAME("51NB EC")
Not sure if all the 51nb devices use the same EC. I'd suggest specifying the EC model (NPCE9... […]
Done
File src/ec/51nb/Makefile.inc:
Patch Set #8, Line 25: $(51NB_EC_INSERT) $(obj)/coreboot.pre \
No, vendor firmware doesn't use the IFD ec region.
Ack
File src/mainboard/51nb/x210/acpi_tables.c:
This file shouldn't be needed anymore
File src/mainboard/51nb/x210/devicetree.cb:
register "PcieRpEnable[2]" = "1" # Ethernet controller
register "PcieRpLtrEnable[2]" = "1"
This is not RP1?
Done
File src/mainboard/51nb/x210/devicetree.cb:
Patch Set #33, Line 167: register "PcieRpHotPlug[3]" = "1"
Hmmmmm... Why do we want hotplug for Wi-Fi only?
Patch Set #33, Line 179: webcam
Please capitalize: `Webcam`
File src/mainboard/51nb/x210/dsdt.asl:
Patch Set #33, Line 33: // CPU
This comment does not add much value. I would drop it
Unnecessary blank line
Patch Set #33, Line 46: // Chipset specific sleep states
This comment was dropped not too long ago
File src/mainboard/51nb/x210/hda_verb.c:
Will do.
Done
File src/mainboard/51nb/x210/hda_verb.c:
Patch Set #33, Line 22: 0x0000000c
12
Patch Set #33, Line 34: 0x17aa2155
This value in the comment might rot away.
0 here and on AZALIA_PIN_CFG macros
Patch Set #33, Line 39: /* Pin Complex (NID 0x19) */
I would drop these as they don't add much info.
File src/mainboard/51nb/x210/mainboard.c:
This seems like Purisms idea of how to store a serial number. […]
Done
File src/mainboard/51nb/x210/romstage.c:
Patch Set #33, Line 31: sizeof(RcompResistor));
Fits on the previous line
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.