Attention is currently required from: Furquan Shaikh. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 2:
(4 comments)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/8f056cd5_53c824b4 PS2, Line 286: system_requires_early_display
As commented earlier, you can use `display_init_required()` here.
will test out with this in next patchset
https://review.coreboot.org/c/coreboot/+/47684/comment/3bf793a1_5cebde10 PS2, Line 296: __weak
I don't think we need the weak implementation. […]
I left a weak here in case it doesn't get implemented and it didn't have a check for display supported before will remove the weak in next patchset
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/comment/bd3dd9d6_27fb2d5f PS2, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data);
Drop this instead of commenting out.
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/1fc005ad_80a6d850 PS2, Line 141: mainboard_early_tcss_enable
I think this should be named `mainboard_fill_tcss_mux_info()` since the enabling is performed by SoC […]
I accidentally added this in the next patch instead of updating it here will move that