Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60782 )
Change subject: mb/google/guybrush/var/dewatt: Update unused GPIO pins ......................................................................
Patch Set 2:
(64 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/60782/comment/0c1ae1ae_f4fbee62 PS1, Line 16: /* Unused TP245*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/97dacbf3_6556bdc1 PS1, Line 17: PAD_NC(GPIO_8),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/37930a4c_d74ca838 PS1, Line 17: PAD_NC(GPIO_8),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/3b4a304b_f8b43e6a PS1, Line 18: /* Unused TP244*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/2d4c206c_e824e1cb PS1, Line 19: PAD_NC(GPIO_11),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/db483215_9de3f355 PS1, Line 19: PAD_NC(GPIO_11),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/89645b24_e2561f07 PS1, Line 20: /* Unused TP194*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/8505c08a_a6d1539e PS1, Line 21: PAD_NC(GPIO_17),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/77cbcdd9_84886b95 PS1, Line 21: PAD_NC(GPIO_17),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/2f057311_1423f76c PS1, Line 22: /* Unused TP195*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/774f9cd7_7493ea60 PS1, Line 23: PAD_NC(GPIO_18),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/ca15b2a1_487908f7 PS1, Line 23: PAD_NC(GPIO_18),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/1d0864c8_5cb5fa06 PS1, Line 24: /* Unused TP243*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/5522053c_e2b17aca PS1, Line 25: PAD_NC(GPIO_21),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/5f939db1_101f3b27 PS1, Line 25: PAD_NC(GPIO_21),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/d7a5953b_5b268998 PS1, Line 26: /* Unused TP196*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/e7864499_b4c17eef PS1, Line 27: PAD_NC(GPIO_24),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/a4f6541e_bb7b99e6 PS1, Line 27: PAD_NC(GPIO_24),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/b1aef25c_77ac0834 PS1, Line 28: /* Unused TP219*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/f409f828_d0af27f9 PS1, Line 29: PAD_NC(GPIO_42),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/5a632a98_86a0f9f9 PS1, Line 29: PAD_NC(GPIO_42),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/e4fb4950_fa838b45 PS1, Line 30: /* Unused TP217*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/b57a9630_5bf39ed0 PS1, Line 31: PAD_NC(GPIO_69),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/8219a924_ad24258a PS1, Line 31: PAD_NC(GPIO_69),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/59054798_2d98642c PS1, Line 32: /* Unused TP235*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/9246e425_ebb1f5a5 PS1, Line 33: PAD_NC(GPIO_115),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/02a2bbbd_56e888b5 PS1, Line 33: PAD_NC(GPIO_115),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/36a985b7_411ef653 PS1, Line 34: /* Unused TP205*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/e942a9a9_cdb2bb75 PS1, Line 35: PAD_NC(GPIO_116),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/b3334fb4_80f8206b PS1, Line 35: PAD_NC(GPIO_116),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/f4027013_3265d7e6 PS1, Line 36: /* Unused TP226*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/061f0b7d_849f9004 PS1, Line 37: PAD_NC(GPIO_140),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/a5de0f43_0f980862 PS1, Line 37: PAD_NC(GPIO_140),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/65a9ba6d_a0b6b9e9 PS1, Line 38: /* Unused TP225*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/be55c60f_3a967da8 PS1, Line 39: PAD_NC(GPIO_142),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/4c847b04_5ea15583 PS1, Line 39: PAD_NC(GPIO_142),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/0c53c188_163dcb0f PS1, Line 40: /* Unused TP227*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/da6e2658_d09c8f51 PS1, Line 41: PAD_NC(GPIO_144),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/cb93b784_99e3a0ba PS1, Line 41: PAD_NC(GPIO_144),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/bf11b3fa_7230d1c8 PS1, Line 45: /* Unused TP245*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/7fa1062e_4bfb5cfa PS1, Line 46: PAD_NC(GPIO_8),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/e334935e_e791e472 PS1, Line 46: PAD_NC(GPIO_8),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/bbb5c30d_cda557c5 PS1, Line 47: /* Unused TP195*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/226bff16_7bd541ff PS1, Line 48: PAD_NC(GPIO_18),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/917740a1_8a12d8f6 PS1, Line 48: PAD_NC(GPIO_18),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/acb7241e_cb121b18 PS1, Line 49: /* Unused TP196*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/b5581167_960623f0 PS1, Line 50: PAD_NC(GPIO_24),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/fea301ea_eb06361d PS1, Line 50: PAD_NC(GPIO_24),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/2f3a648e_e0bd1f79 PS1, Line 51: /* Unused TP217*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/3d321c1d_7d420fb9 PS1, Line 52: PAD_NC(GPIO_69),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/87899ad4_e7878c6e PS1, Line 52: PAD_NC(GPIO_69),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/a5138804_1cbf8e88 PS1, Line 57: /* Unused TP195*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/1f3c47fa_c511463a PS1, Line 58: PAD_NC(GPIO_18),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/4a127b8b_f5e6036a PS1, Line 58: PAD_NC(GPIO_18),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/84758194_323ef924 PS1, Line 59: /* Unused TP217*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/f8600a80_6eb18f5a PS1, Line 60: PAD_NC(GPIO_69),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/fa13dbe3_14e7a007 PS1, Line 60: PAD_NC(GPIO_69),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/692438b9_6bee5974 PS1, Line 65: /* Unused TP196*/
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/b5e7973f_255f9d1e PS1, Line 66: PAD_NC(GPIO_24),
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/a26a9e85_5c8eff75 PS1, Line 66: PAD_NC(GPIO_24),
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/625cac89_6b108fc9 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table);
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/12b3f508_0ff6b668 PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table);
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/3c828006_41c7ee6f PS1, Line 90: return override_bootblock_gpio_table;
code indent should use tabs where possible […]
Done
https://review.coreboot.org/c/coreboot/+/60782/comment/ac4885c6_870b2c12 PS1, Line 90: return override_bootblock_gpio_table;
please, no spaces at the start of a line […]
Done