5 comments:
File src/mainboard/google/kukui/Makefile.inc:
Patch Set #14, Line 38: $(CBFS_COMPRESS_FLAG)
Changed to "none".
Done
File src/mainboard/google/kukui/romstage.c:
Patch Set #1, Line 53: int err = dram_blob_load_and_run();
@hungte Are you okay with that?
only when not found full-calibration param will execute this function in new patch.
https://review.coreboot.org/c/coreboot/+/35110/21/src/mainboard/google/kukui/romstage.c#107
File src/mainboard/google/kukui/romstage.c:
Patch Set #24, Line 36: return -1;
Please add debug messages.
we already print the error value at below position, so I think no need add debug msg here.
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui/romstage.c#55
Patch Set #24, Line 39: return -2;
Please add debug messages.
we already print the error value at below position, so I think no need add debug msg here.
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui/romstage.c#55
Patch Set #24, Line 55: printk(BIOS_ERR, "failed to do full calibration(%d), fall back to load default sdram param\n", err);
1. Please add a space before the opening bracket (. […]
we add some comment at below position, is this ok?
https://review.coreboot.org/c/coreboot/+/35110/21/src/mainboard/google/kukui/romstage.c#119
To view, visit change 34872. To unsubscribe, or for help writing mail filters, visit settings.