Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run DRAM init blob ......................................................................
Patch Set 24:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui... PS14, Line 38: $(CBFS_COMPRESS_FLAG)
Changed to "none".
Done
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/... PS1, Line 53: int err = dram_blob_load_and_run();
@hungte Are you okay with that?
only when not found full-calibration param will execute this function in new patch. https://review.coreboot.org/c/coreboot/+/35110/21/src/mainboard/google/kukui...
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui... PS24, Line 36: return -1;
Please add debug messages.
we already print the error value at below position, so I think no need add debug msg here. https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui...
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui... PS24, Line 39: return -2;
Please add debug messages.
we already print the error value at below position, so I think no need add debug msg here. https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui...
https://review.coreboot.org/c/coreboot/+/34872/24/src/mainboard/google/kukui... PS24, Line 55: printk(BIOS_ERR, "failed to do full calibration(%d), fall back to load default sdram param\n", err);
- Please add a space before the opening bracket (. […]
we add some comment at below position, is this ok? https://review.coreboot.org/c/coreboot/+/35110/21/src/mainboard/google/kukui...