Petr Cvek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35672 )
Change subject: device/pci_early: Drop some __SIMPLE_DEVICE__ use ......................................................................
Patch Set 1:
(2 comments)
I may have had a problem with PCIe x16 detection on kontron 986lcd-m if there was no delay in i945_setup_pci_express_x16(). There is a waiting in pci_bus_reset(). The use of the same wait values (10ms between, 1s after) fixed the problem.
https://review.coreboot.org/c/coreboot/+/35672/1/src/device/pci_early.c File src/device/pci_early.c:
https://review.coreboot.org/c/coreboot/+/35672/1/src/device/pci_early.c@a31 PS1, Line 31: / pci_bus_reset() has 10ms here
https://review.coreboot.org/c/coreboot/+/35672/1/src/device/pci_early.c@a36 PS1, Line 36: pci_write_config16(p2p_bridge, PCI_BRIDGE_CONTROL, reg16); pci_bus_reset() has 1 second delay here