Patch Set 1:
> > > Refer to: https://review.coreboot.org/cgit/coreboot.git/tree/src/arch/x86/acpi_s3.c
 > >
 > > The acpi_is_wakeup() function sets the acpi_slp_type
global
 > > variable, and returns a value based on it. It is necessary
to set
 > > that global variable correctly (hence a function call is
needed),
 > > but no value needs to be returned.
 > >
 > > I would suggest replacing acpi_is_wakeup() with
acpi_handoff_wakeup()
 > > instead.
 >
 > I could see acpi_is_wakeup() function is getting called from
some
 > other place as well. i need to see who is calling this.
> @Angel: Can you please this CL and check if you are seeing any
problem.
> I don't see any problem with CL over for global variable is
getting assigned
Sure, I have a few boards to test this with.

thanks a lot

@Angle, do you have any further observation on this?

View Change

To view, visit change 31140. To unsubscribe, or for help writing mail filters, visit settings.