Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Arthur Heymans.

View Change

1 comment:

• File src/soc/intel/common/block/fast_spi/fast_spi.c:

  • Patch Set #2, Line 486: !CONFIG(SOC_INTEL_APOLLOLAKE)

    IMO, the best option is 4. don't have common `device_operations`. It always […]

    Is it really in scope here? Going away from the common driver approach to a soc specific one while duplicating the code all the way down for every soc? I know that in this case it is mostly Apollo Lake that is badly designed here. Though we have a few ways to go to handle it in the common code.

To view, visit change 64076. To unsubscribe, or for help writing mail filters, visit settings.