Attention is currently required from: Raul Rangel, Martin Roth, Ivy Jian, chris wang.
Patch set 1:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #1:
yeah, the enums are quite misleading. would be good if you open a bug to get that fixed. sure it'll cause some pain for non-upstream boards, but having this source of mistakes is probably worse in the long run
To view, visit change 52948. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac86d2ef5bdd21fbb0a0d4e235efe4fe621023b2
Gerrit-Change-Number: 52948
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Ivy Jian <ivy_jian@compal.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: chris wang <Chris.Wang@amd.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Ivy Jian <ivy_jian@compal.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang@amd.com>
Gerrit-Comment-Date: Wed, 05 May 2021 19:13:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment