Attention is currently required from: Martin Roth, Kevin Chiu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51708 )
Change subject: grunt/barla: add Realtek ALC5682 codec support ......................................................................
Patch Set 1:
(26 comments)
File src/mainboard/google/kahlee/variants/careena/variant.c:
https://review.coreboot.org/c/coreboot/+/51708/comment/db15951a_beb546fb PS1, Line 24: if (!strcmp(config->hid,"10EC5682")) { space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/51708/comment/9a1a24e3_e09c1bc5 PS1, Line 28: break; break is not useful after a goto or return
https://review.coreboot.org/c/coreboot/+/51708/comment/c99568d7_d306394a PS1, Line 34: break; break is not useful after a goto or return
https://review.coreboot.org/c/coreboot/+/51708/comment/da2d218a_8783497b PS1, Line 37: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/51708/comment/72265e42_76a078db PS1, Line 44: printk(BIOS_INFO, "da7219_acpi_device_status from variant\n"); Prefer using '"%s...", __func__' to using 'da7219_acpi_device_status', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/51708/comment/318fdc17_6c53fbc6 PS1, Line 52: switch (sku) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/36d3562f_99c35bb5 PS1, Line 52: switch (sku) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/68ae38b5_687cfab2 PS1, Line 53: default: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/524c4618_6b182491 PS1, Line 54: return ACPI_STATUS_DEVICE_ALL_ON; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/9d20aa06_83a04a0d PS1, Line 54: return ACPI_STATUS_DEVICE_ALL_ON; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/fa21aca0_454ce117 PS1, Line 55: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/8640238f_4e0a9468 PS1, Line 55: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/e32387c1_ea4510ff PS1, Line 56: case SKU_BARLA_ALC5682_44: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/3be51e5e_c82f7c1e PS1, Line 56: case SKU_BARLA_ALC5682_44: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/f1f191f4_5aa56b9b PS1, Line 57: case SKU_BARLA_ALC5682_45: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/898a55f9_6c9373eb PS1, Line 57: case SKU_BARLA_ALC5682_45: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/2f30749c_4ff2190c PS1, Line 58: case SKU_BARLA_ALC5682_46: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/cfebc1e3_02385d72 PS1, Line 58: case SKU_BARLA_ALC5682_46: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/de157601_a7294025 PS1, Line 59: case SKU_BARLA_ALC5682_47: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/2e39a577_bfa31f3b PS1, Line 59: case SKU_BARLA_ALC5682_47: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/21e6ecb2_fbe19658 PS1, Line 60: return ACPI_STATUS_DEVICE_ALL_OFF; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/8717fa91_fa1a032e PS1, Line 60: return ACPI_STATUS_DEVICE_ALL_OFF; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/f69500d0_a95f2a42 PS1, Line 61: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/22b0ff58_06e00a7a PS1, Line 61: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51708/comment/554324c7_4a34ce4c PS1, Line 62: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51708/comment/1458d596_acb2d61b PS1, Line 62: } please, no spaces at the start of a line