Attention is currently required from: Furquan Shaikh, Wonkyu Kim, Subrata Banik, Raj Astekar, Patrick Rudolph.
View Change
2 comments:
File src/acpi/acpi.c:
Patch Set #6, Line 165: if (apic_ids[index] < 0xff)
No need for further indentation, this could be an `else if`.
Patch Set #6, Line 170:
current += acpi_create_madt_lx2apic(
(acpi_madt_lx2apic_t *)current,
index, apic_ids[index]);
This already uses the lx2apic function. Please explain what is wrong
with the existing code.
To view, visit change 51724. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9399d30b686b55d86806f5db4110bf4a80fe459b
Gerrit-Change-Number: 51724
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu@intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik@intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar@intel.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment