Felix Singer submitted this change.
mb/asus/h61-series: Remove superfluous comments related to PCI devices
Since all devicetrees from asus/h61_series are using the reference names
for PCI devices now, remove the equivalent comments documenting their
function.
Change-Id: I1ba2cb08e60cf806c5d749be15265e577a7abc25
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79970
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/mainboard/asus/h61-series/devicetree.cb
M src/mainboard/asus/h61-series/variants/h61m-cs/overridetree.cb
M src/mainboard/asus/h61-series/variants/p8h61-m_lx/overridetree.cb
M src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/overridetree.cb
M src/mainboard/asus/h61-series/variants/p8h61-m_pro/overridetree.cb
M src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/overridetree.cb
6 files changed, 55 insertions(+), 55 deletions(-)
diff --git a/src/mainboard/asus/h61-series/devicetree.cb b/src/mainboard/asus/h61-series/devicetree.cb
index cde0431..7f37acc 100644
--- a/src/mainboard/asus/h61-series/devicetree.cb
+++ b/src/mainboard/asus/h61-series/devicetree.cb
@@ -3,39 +3,39 @@
chip northbridge/intel/sandybridge
register "spd_addresses" = "{0x50, 0, 0x52, 0}"
device domain 0 on
- device ref host_bridge on end # Host bridge
- device ref peg10 on end # PEG
- device ref igd on end # iGPU
+ device ref host_bridge on end
+ device ref peg10 on end
+ device ref igd on end
chip southbridge/intel/bd82x6x
register "sata_port_map" = "0x33"
register "spi_lvscc" = "0x2005"
register "spi_uvscc" = "0x2005"
- device ref mei1 on end # MEI #1
- device ref mei2 off end # MEI #2
- device ref me_ide_r off end # ME IDE-R
- device ref me_kt off end # ME KT
- device ref gbe off end # Intel GbE
- device ref ehci2 on end # EHCI #2
- device ref hda on end # HD Audio
+ device ref mei1 on end
+ device ref mei2 off end
+ device ref me_ide_r off end
+ device ref me_kt off end
+ device ref gbe off end
+ device ref ehci2 on end
+ device ref hda on end
- device ref pcie_rp1 off end # RP #1
- device ref pcie_rp2 off end # RP #2
- device ref pcie_rp3 off end # RP #3
- device ref pcie_rp4 off end # RP #4
- device ref pcie_rp5 off end # RP #5
- device ref pcie_rp6 off end # RP #6
- device ref pcie_rp7 off end # RP #7
- device ref pcie_rp8 off end # RP #8
+ device ref pcie_rp1 off end
+ device ref pcie_rp2 off end
+ device ref pcie_rp3 off end
+ device ref pcie_rp4 off end
+ device ref pcie_rp5 off end
+ device ref pcie_rp6 off end
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
- device ref ehci1 on end # EHCI #1
- device ref pci_bridge off end # PCI bridge
- device ref lpc on end # LPC bridge
- device ref sata1 on end # SATA (AHCI)
- device ref smbus on end # SMBus
- device ref sata2 off end # SATA (Legacy)
- device ref thermal off end # Thermal
+ device ref ehci1 on end
+ device ref pci_bridge off end
+ device ref lpc on end
+ device ref sata1 on end # SATA (AHCI)
+ device ref smbus on end
+ device ref sata2 off end # SATA (Legacy)
+ device ref thermal off end
end
end
end
diff --git a/src/mainboard/asus/h61-series/variants/h61m-cs/overridetree.cb b/src/mainboard/asus/h61-series/variants/h61m-cs/overridetree.cb
index 066136cb..8558510 100644
--- a/src/mainboard/asus/h61-series/variants/h61m-cs/overridetree.cb
+++ b/src/mainboard/asus/h61-series/variants/h61m-cs/overridetree.cb
@@ -5,21 +5,21 @@
subsystemid 0x1043 0x844d inherit
chip southbridge/intel/bd82x6x
register "gen1_dec" = "0x000c0291"
- device ref hda on # High Definition Audio controller
+ device ref hda on
subsystemid 0x1043 0x8445
end
- device ref pcie_rp1 off end # PCIe Port #1
- device ref pcie_rp2 off end # PCIe Port #2
- device ref pcie_rp3 off end # PCIe Port #3
+ device ref pcie_rp1 off end
+ device ref pcie_rp2 off end
+ device ref pcie_rp3 off end
device ref pcie_rp4 on end # PCIe x1 Slot 1 PCIE_1
device ref pcie_rp5 on end # PCIe x1 Slot 2 PCIE_2
device ref pcie_rp6 on # Realtek Gigabit NIC
device pci 00.0 on end
end
- device ref pcie_rp7 off end # PCIe Port #7
- device ref pcie_rp8 off end # PCIe Port #8
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
- device ref lpc on # LPC bridge PCI-LPC bridge
+ device ref lpc on
chip superio/nuvoton/nct6779d
device pnp 2e.1 off end # Parallel
device pnp 2e.2 off end # UART A
diff --git a/src/mainboard/asus/h61-series/variants/p8h61-m_lx/overridetree.cb b/src/mainboard/asus/h61-series/variants/p8h61-m_lx/overridetree.cb
index c4ff6b0..7612c55 100644
--- a/src/mainboard/asus/h61-series/variants/p8h61-m_lx/overridetree.cb
+++ b/src/mainboard/asus/h61-series/variants/p8h61-m_lx/overridetree.cb
@@ -6,7 +6,7 @@
chip southbridge/intel/bd82x6x
register "gen1_dec" = "0x00000295" # Super I/O HWM
- device ref hda on # HD audio controller
+ device ref hda on
subsystemid 0x1043 0x8445
end
device ref pcie_rp1 on end # PCIe 1x slot (PCIEX1_1)
@@ -18,13 +18,13 @@
device pci 00.0 on end
end
end
- device ref pcie_rp4 off end # Unused PCIe port
+ device ref pcie_rp4 off end
device ref pcie_rp5 on end # PCIe 1x slot (PCIEX1_3)
- device ref pcie_rp6 off end # Unused PCIe port
- device ref pcie_rp7 off end # Unused PCIe port
- device ref pcie_rp8 off end # Unused PCIe port
+ device ref pcie_rp6 off end
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
- device ref lpc on # LPC bridge
+ device ref lpc on
chip superio/nuvoton/nct6776
device pnp 2e.0 off end # Floppy
device pnp 2e.1 on # Parallel
diff --git a/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/overridetree.cb b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/overridetree.cb
index fc3313e..1aa08f26 100644
--- a/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/overridetree.cb
+++ b/src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/overridetree.cb
@@ -6,16 +6,16 @@
chip southbridge/intel/bd82x6x
register "gen1_dec" = "0x000c0291"
- device ref pcie_rp1 on end # RP #1
- device ref pcie_rp2 off end # RP #2
- device ref pcie_rp3 off end # RP #3
- device ref pcie_rp4 on end # RP #4: PCIEX1_1
- device ref pcie_rp5 on end # RP #5: PCIEX1_2
- device ref pcie_rp6 on end # RP #6: RTL8111 GbE NIC
- device ref pcie_rp7 off end # RP #7
- device ref pcie_rp8 off end # RP #8
+ device ref pcie_rp1 on end
+ device ref pcie_rp2 off end
+ device ref pcie_rp3 off end
+ device ref pcie_rp4 on end # PCIEX1_1
+ device ref pcie_rp5 on end # PCIEX1_2
+ device ref pcie_rp6 on end # RTL8111 GbE NIC
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
- device ref lpc on # LPC bridge
+ device ref lpc on
chip superio/nuvoton/nct6779d
device pnp 2e.1 off end # Parallel
device pnp 2e.2 off end # UART A
diff --git a/src/mainboard/asus/h61-series/variants/p8h61-m_pro/overridetree.cb b/src/mainboard/asus/h61-series/variants/p8h61-m_pro/overridetree.cb
index 026bd81..59c2a14 100644
--- a/src/mainboard/asus/h61-series/variants/p8h61-m_pro/overridetree.cb
+++ b/src/mainboard/asus/h61-series/variants/p8h61-m_pro/overridetree.cb
@@ -7,7 +7,7 @@
device ref pcie_rp1 on end # PCIe x1 Port (PCIEX1_1)
device ref pcie_rp2 on end # PCIe x1 Port (PCIEX1_2)
- device ref pcie_rp3 on # Realtek RTL8111E Ethernet Controller
+ device ref pcie_rp3 on # Realtek RTL8111E Ethernet Controller
chip drivers/net
register "customized_leds" = "0x00f6"
register "wake" = "9"
@@ -17,10 +17,10 @@
device ref pcie_rp4 on end # ASMedia ASM1042 USB3 Controller
device ref pcie_rp5 on end # PCIe x1 Port, x16 size (PCIEX16_2)
device ref pcie_rp6 on end # ASMedia ASM1062 SATA Controller
- device ref pcie_rp7 off end # Unused PCIe Port
- device ref pcie_rp8 off end # Unused PCIe Port
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
- device ref lpc on # LPC bridge
+ device ref lpc on
chip superio/nuvoton/nct6776
device pnp 2e.0 off end # Floppy
device pnp 2e.1 on # Parallel port
diff --git a/src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/overridetree.cb b/src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/overridetree.cb
index 9db03fc..ef22ce5 100644
--- a/src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/overridetree.cb
+++ b/src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/overridetree.cb
@@ -8,7 +8,7 @@
device ref pcie_rp1 on end # PCIe x1 Port (PCIEX1_1)
device ref pcie_rp2 on end # PCIe x1 Port (PCIEX1_2)
- device ref pcie_rp3 on # Realtek RTL8111E Ethernet Controller
+ device ref pcie_rp3 on # Realtek RTL8111E Ethernet Controller
chip drivers/net
register "customized_leds" = "0x00f6"
register "wake" = "9"
@@ -16,10 +16,10 @@
end
end
device ref pcie_rp4 on end # ASMedia ASM1042 USB3 Controller
- device ref pcie_rp5 on end # RP #6: ASM1083 PCI Bridge
+ device ref pcie_rp5 on end # ASM1083 PCI Bridge
device ref pcie_rp6 on end # ASMedia ASM1062 SATA Controller
- device ref pcie_rp7 off end # Unused PCIe Port
- device ref pcie_rp8 off end # Unused PCIe Port
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
device ref lpc on # LPC bridge
chip superio/nuvoton/nct6776
To view, visit change 79970. To unsubscribe, or for help writing mail filters, visit settings.