Hmmm, I remember some resistance towards these correct-by-definition
but unnecessary-given-we-know-the-compiler changes. I guess we should
have a broader discussion about it at some point.
Personally, I'm ok with it. Would prefer `1u`, though (lower case
to be more distinct from the number part, and the `L` doesn't seem
needed).
Patch set 1:Code-Review +1
1 comment:
Patch Set #1, Line 7: arch/x86/include/arch/pci_io_cfg.h: Fix UndefinedBehavior sanitizer complain
"Fix <tool> complaining" isn't a good description. Such changes sometimes
turn out to be wrong even if they silence something. Better describe what
is actually wrong, e.g.
arch/x86/pci_io_cfg.h: Fix undefined behaviour in left-shift
(the prefix doesn't have to be a full path)
To view, visit change 49076. To unsubscribe, or for help writing mail filters, visit settings.