Furquan Shaikh has uploaded this change for review.

View Change

soc/intel/icelake: Get rid of unused dev param

This change gets rid of unused dev param to pmc_set_afterg3.

BUG=b:136861224

Change-Id: I861bb132acf113c9d306175b670bf4a1ff742c28
Signed-off-by: Furquan Shaikh <furquan@google.com>
---
M src/soc/intel/icelake/pmc.c
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/34119/1
diff --git a/src/soc/intel/icelake/pmc.c b/src/soc/intel/icelake/pmc.c
index 25913a8..053d7e8 100644
--- a/src/soc/intel/icelake/pmc.c
+++ b/src/soc/intel/icelake/pmc.c
@@ -30,7 +30,7 @@
* Set which power state system will be after reapplying
* the power (from G3 State)
*/
-static void pmc_set_afterg3(struct device *dev, int s5pwr)
+static void pmc_set_afterg3(int s5pwr)
{
uint8_t reg8;
uint8_t *pmcbase = pmc_mmio_regs();
@@ -58,7 +58,7 @@
*/
void pmc_soc_restore_power_failure(void)
{
- pmc_set_afterg3(PCH_DEV_PMC, CONFIG_MAINBOARD_POWER_FAILURE_STATE);
+ pmc_set_afterg3(CONFIG_MAINBOARD_POWER_FAILURE_STATE);
}

static void config_deep_sX(uint32_t offset, uint32_t mask, int sx, int enable)
@@ -102,7 +102,7 @@
write32(pmcbase + DSX_CFG, reg);
}

-static void pch_power_options(struct device *dev)
+static void pch_power_options(void)
{
const char *state;

@@ -127,7 +127,7 @@
default:
state = "undefined";
}
- pmc_set_afterg3(dev, pwr_on);
+ pmc_set_afterg3(pwr_on);
printk(BIOS_INFO, "Set power %s after power failure.\n", state);

/* Set up GPE configuration. */
@@ -142,7 +142,7 @@
rtc_init();

/* Initialize power management */
- pch_power_options(dev);
+ pch_power_options();

pmc_set_acpi_mode();


To view, visit change 34119. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I861bb132acf113c9d306175b670bf4a1ff742c28
Gerrit-Change-Number: 34119
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: newchange