Patch Set 2:

commit message says "8 MiB flash" here. Also, why not "a and b",
like https://review.coreboot.org/c/coreboot/+/29816 tries to do?

I just copied the commit message.

Also, some hints on how to test would be great in order to get it
tested :) thanks!


Enable CONFIG_VBOOT and CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW on default config.
It will boot RW_MAIN_A/RW_MAIN_B on regular boot and WP_RO if you hold Fn-Key on boot.

thanks. now the vboot-rwa.fmd filenames suggest "a only". shouldn't that be "vboot-rw-ab.fmd" or "vboot-rwab.fmd"? As a different board has "vboot-ro.fmd" already, I guess this should match the content...

View Change

To view, visit change 32617. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a35a06ece1e9d57a2ef23970e61ae26fafce543
Gerrit-Change-Number: 32617
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Kepplinger <martink@posteo.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 07 May 2019 13:00:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment