Patch Set 1:

Please add it under commonlib and use qsort.

I agree with the commonlib-part, will move it to this location.
Regarding the algorithm itself I would like tostick with bubblesort for the following reasons:
-it is simple
-it might turn out that there is a need for a stable sorting algo. Qsort is not stable while bubble sort is
-The amount of data to sort in this given case (acpi MADT) is short (up to MAX_CPUS). There is no benefit in qsort vs. bubblesort on this data set
-bubblesort does not need to stay the only algo in sort.c. It is more meant as a general location for different sorting algos, which can be added on demand there.

View Change

To view, visit change 31544. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c5e0b5685a907243b58ebe6682078272d316bf6
Gerrit-Change-Number: 31544
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Thu, 21 Feb 2019 08:26:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment