1 comment:
File src/drivers/spi/winbond.c:
Patch Set #2, Line 211: static int winbond_get_bpbits(const struct spi_flash *flash,
Please don't forward declare static functions, just reorder the functions until that's unnecessary ( […]
I did this quite on purpose because it made the diff significantly smaller and easier to review. If I had reordered the functions we would be getting all sorts of funky interleaving of added/removed blocks from the two functions.
Happy to do just the reordering in another commit though.
To view, visit change 42114. To unsubscribe, or for help writing mail filters, visit settings.