[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/volteer/variants/drobit: fix power_limits_config

[Ingo Reitz (Code Review)]

Attention is currently required from: Ariel Chang, Nick Vaccaro, Paul Menzel, Paul Yang, Wayne3 Wang.

Ingo Reitz has posted comments on this change by Ingo Reitz. ( https://review.coreboot.org/c/coreboot/+/86026?usp=email )

Change subject: mb/google/volteer/variants/drobit: fix power_limits_config
......................................................................

Patch Set 6:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86026/comment/a63474a4_1f12623a?usp... :
PS4, Line 7: volteer/drobit
> Add variants in between?

Done

https://review.coreboot.org/c/coreboot/+/86026/comment/fd322ef9_e51a388e?usp... :
PS4, Line 9: little power usage and very low clock speeds under load
> Concrete values would be nice.

Done

https://review.coreboot.org/c/coreboot/+/86026/comment/c4a3b3ef_e671f8ca?usp... :
PS4, Line 15: temperature
> It‘d be great if you could be more specific.

Done

https://review.coreboot.org/c/coreboot/+/86026/comment/e3a4ab72_7037039e?usp... :
PS4, Line 15: correct power usage, clock speeds temperature
> It’d be great if you added the specific values.

Done

https://review.coreboot.org/c/coreboot/+/86026/comment/9a586a59_0dad4e06?usp... :
PS4, Line 15: speeds
> Comma after *speeds*?

Reworded

https://review.coreboot.org/c/coreboot/+/86026/comment/66d3d618_0c36e303?usp... :
PS4, Line 15: Tested
> No idea if there are different CPU models in drobit, but it’d be great if you listed yours.

Done

https://review.coreboot.org/c/coreboot/+/86026/comment/04d01ac5_e7aaadf9?usp... :
PS4, Line 16: 100% load
> How do you create this load?

Done