Patch set 24:Code-Review +1

View Change

4 comments:

• File Documentation/mainboard/51nb/x210.md:

  • Patch Set #24, Line 1: # 51NB X210

    file needs to be referenced by index.md

  • Patch Set #24, Line 19: is located on the upper side of the motherboard, below the keyboard

    can you provide a picture?
    Note: pictures should not be bigger than 800px and use 70% compression to keep size small.

  • Patch Set #24, Line 31: Use libgfxinit once Kaby Lake is supported.

    isn't that supported by now?

• File src/ec/51nb/npce985la0dx/npce985la0dx.c:

  • Patch Set #24, Line 19: { NULL, 0x05 }, { NULL, 0x06 }, { NULL, 0x11 }

    what are those LDNs used for? Do you need to set additional registers in the superio space?

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.